Lazy evaluate ActionController session store middleware class to pick…

…up custom plugin session stores [rails#2001 state:resolved]
alloy · Feb 20, 2009 · 140f0ab · 140f0ab
1 parent 61a9d1d
commit 140f0ab
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/actionpack/lib/action_controller/middleware_stack.rb b/actionpack/lib/action_controller/middleware_stack.rb
@@ -27,7 +27,9 @@ def initialize(klass, *args, &block)
       end
 
       def klass
-        if @klass.is_a?(Class)
+        if @klass.respond_to?(:call)
+          @klass.call
+        elsif @klass.is_a?(Class)
           @klass
         else
           @klass.to_s.constantize
@@ -37,6 +39,8 @@ def klass
       end
 
       def active?
+        return false unless klass
+
         if @conditional.respond_to?(:call)
           @conditional.call
         else

diff --git a/actionpack/lib/action_controller/middlewares.rb b/actionpack/lib/action_controller/middlewares.rb
@@ -4,17 +4,8 @@
 
 use "ActionController::Failsafe"
 
-["ActionController::Session::CookieStore",
- "ActionController::Session::MemCacheStore",
- "ActiveRecord::SessionStore"].each do |store|
-   use(store, ActionController::Base.session_options,
-      :if => lambda {
-        if session_store = ActionController::Base.session_store
-          session_store.name == store
-        end
-      }
-    )
-end
+use lambda { ActionController::Base.session_store },
+  ActionController::Base.session_options
 
 use "ActionController::RewindableInput"
 use "ActionController::ParamsParser"

diff --git a/actionpack/test/controller/middleware_stack_test.rb b/actionpack/test/controller/middleware_stack_test.rb
@@ -73,4 +73,11 @@ def setup
       end
     end
   end
+
+  test "lazy evaluates middleware class" do
+    assert_difference "@stack.size" do
+      @stack.use lambda { BazMiddleware }
+    end
+    assert_equal BazMiddleware, @stack.last.klass
+  end
 end