Work around enumerable string deprecation warnings

alloy · Feb 6, 2009 · 86dcfdc · 86dcfdc
1 parent 86dd2f8
commit 86dcfdc
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/activesupport/lib/active_support/testing/assertions.rb b/activesupport/lib/active_support/testing/assertions.rb
@@ -32,12 +32,15 @@ module Assertions
       #     post :delete, :id => ...
       #   end
       def assert_difference(expressions, difference = 1, message = nil, &block)
-        expression_evaluations = Array(expressions).collect{ |expression| lambda { eval(expression, block.send(:binding)) } }
+        case expressions
-
+        when String
-        original_values = expression_evaluations.inject([]) { |memo, expression| memo << expression.call }
+          before = eval(expressions, block.send(:binding))
-        yield
+          yield
-        expression_evaluations.each_with_index do |expression, i|
+          assert_equal(before + difference, eval(expressions, block.send(:binding)), message)
-          assert_equal original_values[i] + difference, expression.call, message
+        when Enumerable
+          expressions.each { |e| assert_difference(e, difference, message, &block) }
+        else
+          raise ArgumentError, "Unrecognized expression: #{expressions.inspect}"
         end
       end