Add log message when successfully applying options from cmdline #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a log message with level INFO when the user's specified parameters on the cli are successfuly set.
|
Dear @mmoanis thanks for the PR. May I suggest a slight rephrasing? I think printing a message similar to LOG(INFO) << "Setting command line option " << key_value.first << '=' << key_value.second;might be more helpful to users. Or maybe Apart from that it'd be nice if you could add yourself to the alphabetical list of authors (with affiliation) in the Best, |
|
Dear @simonspa I updated the message. Ready for review. |
|
Merged via https://gitlab.cern.ch/allpix-squared/allpix-squared/merge_requests/206 Thank you very much, @mmoanis |
mmoanis
pushed a commit
to mmoanis/allpix-squared
that referenced
this pull request
May 21, 2019
# This is the 1st commit message: update deleted: ../etc/jadepix_manual.conf deleted: ../etc/jadepix_sensor.conf deleted: ../field/example_electric_field.init deleted: ../field/n30_dfise.grd deleted: ../field/n30_dfise_ElectricField.init modified: ../models/CMakeLists.txt modified: ../models/jadepix.conf add field tools add cluser and seed add EFAna update # This is the commit message allpix-squared#2: add EFGen # This is the commit message allpix-squared#3: deleted: run/CMakeLists.txt deleted: run/Makefile deleted: run/conf/jadepix_manual.conf deleted: run/conf/jadepix_sensor.conf deleted: run/conf/jadepix_user.conf deleted: run/conf/jadepix_user_origin.conf deleted: run/conf/jadepix_user_test.conf deleted: run/include/EFConvert.hh deleted: run/include/EFReadDFISE.hh deleted: run/include/EFString.hh deleted: run/include/EField.hh deleted: run/include/Octree.hpp deleted: run/src/EFAna.cc deleted: run/src/EFConvert.cc deleted: run/src/EFGen.cc deleted: run/src/EFReadDFISE.cc deleted: run/src/EField.cc deleted: run/src/EFieldTest.cc deleted: run/src/combine.cc deleted: run/src/convert.cc deleted: run/src/genApx.cc deleted: run/src/sourceAdd.cc deleted: run/submit.sh # This is the commit message allpix-squared#4: source change # This is the commit message allpix-squared#5: remove four files from Liejian # This is the commit message allpix-squared#6: add back default CMakeLists # This is the commit message allpix-squared#7: rename conf # This is the commit message allpix-squared#8: add model path # This is the commit message allpix-squared#9: fix typo # This is the commit message allpix-squared#10: roll back # This is the commit message allpix-squared#11: Ran make format successfully # This is the commit message allpix-squared#12: Run clang-format v5.0.1 # This is the commit message allpix-squared#13: fix some bugs about considering particle_type and particle_code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user uses the command line options
-gor-oto specify some parameter for a module or a detector, there is no indication about whether this option was set correctly or not which may cause confusion. For example, a user might make a typo in a parameter name and expects that the parameter was set correctly while it wasn't.IMHO, adding an INFO level log message when the user's specified parameters on the command line are successfully set would help to make it clear about the configuration used during the simulation.