Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Remove dependency of NUnit from AllureCSharpCommon. #8

Closed
wants to merge 4 commits into from

Conversation

arpitgold
Copy link

AllureCSharpeCommon is common library for integrate Allure with C#. But it has a dependency with NUnit. So user (like me) who is not using NUnit in there project, bound to use NUnit.
This pull request removed dependency of NUnit from Core framework(AllureCSharpeCommon). So that user can use it with any testing Framework like : MSTest, XUnit etc.

@vania-pooh
Copy link

@arpitgold the build should pass to merge this.

@arpitgold
Copy link
Author

Hi vania-pooh,
I am not sure, Whether it is a correct implementation or not.
I know its not a right way to change a testcase. So I am closing this pull request. Please check whether It can be possible to remove NUnit from AllureCSharpCommon by your own implementation.

Thanks
Arpit

@arpitgold arpitgold closed this Sep 4, 2014
@arpitgold arpitgold reopened this Sep 4, 2014
@arpitgold
Copy link
Author

Hi Ivan,
Can you please look into it.

Thanks
Arpit

@ilya-murzinov
Copy link
Contributor

@arpitgold
Well, ok, I understand the problem, but you solution doesn't seem right, because you added your own exception and it will never be thrown.

The problem is that in Java there is java.lang.AssertionError which is supercalss for any exception which test frameworks throw. So any exception in Java is java.lang.AssertionError.
But in .NET there is no base class for exceptions so it's impossible to distinguish them crom other exceptions without dependency on concrete test framework.

This problem needs further investigation.

@arpitgold
Copy link
Author

Yeah, that's correct. Please look into it, if you found any solutions for this.

@arpitgold
Copy link
Author

Have you got the time to look into it ?

@vania-pooh
Copy link

@ilya-murzinov thoughts?

@ilya-murzinov
Copy link
Contributor

see #9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants