Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allure-xunit: Catastrophic failure if allureConfig.json doesn't exist #381

Closed
1 of 3 tasks
delatrie opened this issue Sep 18, 2023 · 0 comments · Fixed by #393
Closed
1 of 3 tasks

allure-xunit: Catastrophic failure if allureConfig.json doesn't exist #381

delatrie opened this issue Sep 18, 2023 · 0 comments · Fixed by #393
Assignees
@delatrie
Labels
bug theme:xunit

Comments

@delatrie
Copy link
Contributor

I'm submitting a ...

  • bug report
  • feature request
  • support request => Please do not submit support request here, see note at the top of this template.

What is the current behavior?

Allure.XUnit aborts the test execution if no allureConfig.json file exists.

What is the expected behavior?

Absence of allureConfig.json shouldn't affect a test run. Reasonable defaults should be provided in such a case.

What is the motivation / use case for changing the behavior?

Make Allure.XUnit easier to use out of the box.

Please tell us about your environment:

  • Test framework: xunit@2.4.1
  • Allure adapter: allure-xunit@2.9.5-preview.1
  • Generate report using: dotnet@7.0.401
@delatrie delatrie self-assigned this Sep 18, 2023
delatrie added a commit that referenced this issue Oct 3, 2023
@delatrie
allure-xunit: provide default config when allureConfig.json is missing
73183ef 
Fixes #381
delatrie added a commit that referenced this issue Oct 10, 2023
@delatrie
allure-xunit: provide default config when allureConfig.json is missing
c4060ce 
Fixes #381
@delatrie delatrie mentioned this issue Oct 10, 2023
Merged
2 tasks
@delatrie delatrie linked a pull request Oct 10, 2023 that will close this issue
Fix regression: non-working lambda-steps and lambda-fixtures API #393
Merged
2 tasks
neparij pushed a commit that referenced this issue Oct 11, 2023
@delatrie
Fix regression: non-working lambda-steps and lambda-fixtures API (#393)
6520f76 
* allure-xunit: provide default config when allureConfig.json is missing

Fixes #381

* Fix async step/fixture wrapper functions

  - make async Step, Before and After obey .NET's ExecutionContext capturing rules
  - refactor CoreStepsHelper to be more testable
  - write tests for CoreStepsHelper's Step, Before and After

More tests are needed to fully cover CoreStepsHelper.

Fixes #383
Fixed #388

* Add async suffix to private step methods

This helps to make distinction more clear to a reader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delatrie delatrie

Labels
bug theme:xunit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression: non-working lambda-steps and lambda-fixtures API allure-framework/allure-csharp
1 participant
@delatrie