Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facelift: split plugin to several ones, implement aggregation, migrate to Kotlin #61

Merged
merged 13 commits into from
Jul 5, 2021

Conversation

vlsi
Copy link
Contributor

@vlsi vlsi commented Apr 27, 2021

This PR reworks allure-gradle plugin implementation solving all (?) the currently open issues, and making the use more predictable and user-friendly.

Note: GitHub Actions are not configured for allure-gradle yet, so you could check CI results at https://github.com/vlsi/allure-gradle/actions and in Gradle Build Scan (see link at the end of the run like https://scans.gradle.com/s/ylw72oz2r5nso/tests )

Here's the updated readme: https://github.com/vlsi/allure-gradle/tree/facelift

The PR is more-or-less ready.

Open questions

  • Should other adapters (e.g. allure-selenide) be auto-detected by default?

Missing bits

  • need test coverage of the new syntax in Groovy DSL
  • signing and publishing (publishing to Central did not exist)
  • ktlint? (Kotlin linting did not exist in allure-gradle)

Tests

There are test failures, however, it looks like they identify true bugs:

Notes

Checklist

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2021

CLA assistant check
All committers have signed the CLA.

@vlsi
Copy link
Contributor Author

vlsi commented Apr 27, 2021

UPD: renamed collect -> gather


Unfortunately, the naming of collect extension clashes with Groovy's Object#collect method :((( https://docs.groovy-lang.org/latest/html/groovy-jdk/java/lang/Object.html#collect(groovy.lang.Closure)

plugins {
    id("io.qameta.allure-collect") // <-- this probably needs renaming
    id("io.qameta.allure-report")
}

allure {
    collect { // <-- this clashes with Groovy's Object.collect(Closure)
        ...

Does anybody have other ideas for the name?

@vlsi
Copy link
Contributor Author

vlsi commented Apr 28, 2021

JFrog announced they would keep read-only JCenter: https://twitter.com/steveonjava/status/1387072410868797440

I am not sure if it makes sense to support "pre 2.8.0 allure versions" though. I guess the users could just upgrade.

For now, I removed all jcenter-related tests.

vlsi added 3 commits May 1, 2021 14:11
Note: the main plugin project uses Gradle 6.8.3 for better backward compatibility
with previous Gradle verisons.

See gradle/gradle#16781

Sandbox uses Gradle 7 to see that the plugin is usable from Gradle 7
@vlsi
Copy link
Contributor Author

vlsi commented May 1, 2021

@eroshenkoam
Copy link
Member

@baev lgtm?

@eroshenkoam eroshenkoam merged commit b6ccd62 into allure-framework:master Jul 5, 2021
@smohylevskyi
Copy link

@eroshenkoam is there any information on when this change is going to be released?

@smohylevskyi
Copy link

@vlsi maybe some insight from you on when this change might be released?
Thanks!

@alexsirko
Copy link

alexsirko commented Aug 9, 2021

@eroshenkoam are there any updates regarding release date of this change? We would love to use latest Gradle with Allure in our project...

@eroshenkoam eroshenkoam added the type:improvement Change that improves some user experience but can't be considered as a new feature label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement Change that improves some user experience but can't be considered as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants