Add jdk9 support #249
Merged
Add jdk9 support #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baev
requested changes
Oct 18, 2018
settings.gradle
Outdated
| @@ -41,3 +42,5 @@ examples.forEach({ | |||
| include "examples/$it" | |||
| project(":examples/$it").name = it | |||
| }) | |||
| include 'allure-model' | |||
build.gradle
Outdated
|
|
||
| dependency 'ru.yandex.qatools.matchers:nio-matchers:1.3' | ||
| dependency 'com.fasterxml.jackson.core:jackson-databind:2.7.0' | ||
| dependency 'com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.7.0' |
There was a problem hiding this comment.
no need to have this dependency any more
build.gradle
Outdated
| @@ -100,6 +99,13 @@ subprojects { project -> | |||
| dependency 'org.springframework:spring-webmvc:4.3.18.RELEASE' | |||
| dependency 'org.testng:testng:6.14.3' | |||
| dependency 'net.javacrumbs.json-unit:json-unit:2.0.0.RC1' | |||
|
|
|||
| dependency 'ru.yandex.qatools.matchers:nio-matchers:1.3' | |||
There was a problem hiding this comment.
please rewrite tests using Assertj and remove this dependency
build.gradle
Outdated
| dependency 'com.fasterxml.jackson.core:jackson-databind:2.7.0' | ||
| dependency 'com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.7.0' | ||
| dependency 'org.apache.tika:tika-core:1.14' | ||
| dependency 'commons-codec:commons-codec:1.11' |
There was a problem hiding this comment.
if this only used for converting bytes to hex string consider removing dependency and using the following util method:
return new BigInteger(1, bytes).toString(16);| * <p>The following schema fragment specifies the expected content contained within this class. | ||
| * | ||
| * <pre> | ||
| * <complexType name="TestResult"> |
allure-model/build.gradle
Outdated
| dependencies { | ||
|
|
||
| compile('com.fasterxml.jackson.core:jackson-databind') | ||
| compile('com.fasterxml.jackson.module:jackson-module-jaxb-annotations') |
| return DatatypeConverter.printHexBinary(getMessageDigest() | ||
| .digest(string.getBytes(StandardCharsets.UTF_8)) | ||
| ); | ||
| return new String(Hex.encodeHex(getMessageDigest() |
There was a problem hiding this comment.
return new BigInteger(1, bytes).toString(16);| } | ||
|
|
||
| @Override | ||
| public TestResult withName(final String value) { |
There was a problem hiding this comment.
add deprecation. Also comment should be scheduled to remove in 3.0 release. Use setter method instead
build.gradle
Outdated
| dependency 'ru.yandex.qatools.matchers:nio-matchers:1.3' | ||
| dependency 'com.fasterxml.jackson.core:jackson-databind:2.7.0' | ||
| dependency 'com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.7.0' | ||
| dependency 'org.apache.tika:tika-core:1.14' |
There was a problem hiding this comment.
use latest version since org.apache.tika:tika-core < 1.18 has security vulnerability
3 tasks
baev
force-pushed
the
add-jdk9-support
branch
from
3ffb6af
to
f142b04
Compare
baev
approved these changes
Oct 26, 2018
baev
force-pushed
the
add-jdk9-support
branch
from
cdf3e9d
to
ac6605b
Compare
eroshenkoam
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #208