-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 475 introduce new cucumber allure world #491
Conversation
38d281f
to
b7d55b0
Compare
add allure attachment messages handlers
f4d58d5
to
fe04729
Compare
1ce8be8
to
494b2f1
Compare
@@ -0,0 +1,329 @@ | |||
import process from "node:process"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please clenup unused imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good overall.
allure-results generated successfully in paralell mode but report something goes wrong with attachments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine.
Report in parallel mode works fine in example tests. (I imagine if we have big cucumber project to test on)
Some changes to readme and we fine to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👻 LGTM
Tested locally
fixes #475
Context
Changes the logic for work with nested steps and their labels and attachments introducing our own enhanced World implementation.
Example:
If you want to keep the functoinality in
parallel
mode, setCucumberAllureWorld
as world constructor:Checklist