Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cucumberjs reporter on windows #494

Merged
merged 2 commits into from
Sep 12, 2022
Merged

fix cucumberjs reporter on windows #494

merged 2 commits into from
Sep 12, 2022

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Sep 6, 2022 •
edited

Context

fixes #492

Use process.pid as fallback value for THREAD label

Checklist

@epszaw epszaw added type:bug Something isn't working theme:cucumberjs CucumberJS related issue labels Sep 6, 2022
@epszaw epszaw requested a review from baev September 6, 2022 07:35
@epszaw epszaw marked this pull request as ready for review September 6, 2022 07:36
vovsemenv
vovsemenv approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@vovsemenv vovsemenv left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it works.

But thread labels isn't correct. Currently just mark all tests with current reporter process. Need worker Id from cucumber team i guess.

image

@baev baev changed the title fix getuid error fix cucumberjs reporter on windows Sep 12, 2022
@baev baev merged commit 4122761 into master Sep 12, 2022
@baev baev deleted the fix-getuid branch September 12, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

@vovsemenv vovsemenv vovsemenv approved these changes

Assignees
No one assigned
Labels
theme:cucumberjs CucumberJS related issue type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run scenario after update to 2.0.0-beta.19
3 participants
@epszaw @baev @vovsemenv