Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate prefixes for the commons package #939

Merged
merged 7 commits into from
May 16, 2024
Merged

Deprecate prefixes for the commons package #939

merged 7 commits into from
May 16, 2024

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented May 16, 2024

Context

Checklist

@github-actions github-actions bot added theme:api Javascript API related issue theme:mocha Mocha related issue theme:jest Jest related issue theme:cucumberjs CucumberJS related issue theme:jasmine Jasmine related issue theme:playwright theme:newman theme:codeceptjs theme:vitest labels May 16, 2024
@epszaw epszaw added type:internal theme:commons and removed theme:api Javascript API related issue theme:mocha Mocha related issue theme:jest Jest related issue theme:cucumberjs CucumberJS related issue theme:jasmine Jasmine related issue theme:playwright theme:newman theme:codeceptjs theme:vitest labels May 16, 2024
@github-actions github-actions bot added theme:api Javascript API related issue theme:mocha Mocha related issue theme:jest Jest related issue theme:cucumberjs CucumberJS related issue theme:jasmine Jasmine related issue theme:playwright theme:newman theme:codeceptjs labels May 16, 2024
@epszaw epszaw force-pushed the deprecate-commons-prefixes branch from 508261e to 99c35a8 Compare May 16, 2024 13:12
@epszaw epszaw requested a review from baev May 16, 2024 13:32
baev
baev requested changes May 16, 2024
View reviewed changes
packages/allure-codeceptjs/test/spec/links.test.ts Outdated Show resolved Hide resolved
packages/allure-jest/test/spec/links.test.ts Outdated Show resolved Hide resolved
packages/allure-jest/test/spec/steps.test.ts Outdated Show resolved Hide resolved
packages/allure-jest/test/spec/steps.test.ts Outdated Show resolved Hide resolved
packages/allure-jest/test/spec/steps.test.ts Outdated Show resolved Hide resolved
packages/allure-jest/test/spec/steps.test.ts Outdated Show resolved Hide resolved
packages/allure-jest/test/spec/steps.test.ts Outdated Show resolved Hide resolved
packages/allure-jest/test/spec/steps.test.ts Outdated Show resolved Hide resolved
packages/allure-jest/test/spec/steps.test.ts Outdated Show resolved Hide resolved
packages/allure-playwright/test/spec/tags.spec.ts Outdated Show resolved Hide resolved
@epszaw @baev
fix typos
98504b0 
Co-authored-by: Dmitry Baev <baev.dm@gmail.com>
@baev baev merged commit 6ec0d00 into main May 16, 2024
8 checks passed
@baev baev deleted the deprecate-commons-prefixes branch May 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

Assignees
No one assigned
Labels
theme:api Javascript API related issue theme:codeceptjs theme:commons theme:cucumberjs CucumberJS related issue theme:jasmine Jasmine related issue theme:jest Jest related issue theme:mocha Mocha related issue theme:newman theme:playwright theme:vitest type:internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@epszaw @baev