Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix historyId calculation by allure-pytest (fix #743, #744) #745

Merged
merged 2 commits into from Apr 26, 2023
Merged

Fix historyId calculation by allure-pytest (fix #743, #744) #745

merged 2 commits into from Apr 26, 2023

Conversation

delatrie
Copy link
Contributor

@delatrie delatrie commented Apr 23, 2023 •
edited

Context

This PR fixes a couple of issues regarding historyId

  1. Allure-pytest now takes into account non-excluded dynamic parameters when calculating historyId.
  2. Assigning or changing an id of a pytest parameter set now doesn't affect historyId.
  3. Reordering of parameters (both pytest-provided and/or dynamic) now doesn't affect how allure-pytest calculates historyId.

Other changes

  1. allure_commons.utils.md5 now may take any value, not only strings.
  2. Add missed issue link to one of the tests.
  3. Fix pytest runner crash with an unhelpful AttributeError when trying to execute a non-existing docstring.

Checklist

Closes #743
Closes #744
Enables #430

@delatrie delatrie added bug Something isn't working theme:pytest labels Apr 23, 2023
@delatrie delatrie self-assigned this Apr 23, 2023
@delatrie delatrie requested a review from skhomuti April 23, 2023 18:49
@delatrie delatrie marked this pull request as ready for review April 24, 2023 07:42
@delatrie delatrie merged commit 8e7b2ae into master Apr 26, 2023
34 checks passed
@delatrie delatrie deleted the i743-historyId-fix branch April 26, 2023 09:02
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
@delatrie
Fix historyId calculation by allure-pytest (fix allure-framework#743, a…
74b5733 
…llure-framework#744) (allure-framework#745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhomuti skhomuti skhomuti approved these changes

Assignees

@delatrie delatrie

Labels
bug Something isn't working theme:pytest
Projects
None yet
Milestone
No milestone
2 participants
@delatrie @skhomuti