Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suite label duplication when using dynamic suite functions (Fixes #586) #746

Merged
merged 1 commit into from Apr 25, 2023

Conversation

delatrie
Copy link
Contributor

@delatrie delatrie commented Apr 24, 2023

Context

Allure-pytest defines default suite labels: parentSuite (optional), suite and subSuite (optional).
If an author of a test uses a decorator (e.g., @allure.suite) to assign a custom suite label to a test, allure-pytest doesn't add its default counterpart.

This PR extends this behavior to cover suites added dynamically (e.g., with allure.dynamic.suite) as well.

Checklist

Closes #586

@delatrie delatrie requested a review from skhomuti April 24, 2023 16:19
@delatrie delatrie marked this pull request as ready for review April 24, 2023 16:28
@delatrie delatrie added bug Something isn't working theme:pytest labels Apr 24, 2023
@delatrie delatrie self-assigned this Apr 24, 2023
@delatrie delatrie merged commit 14624e4 into master Apr 25, 2023
9 checks passed
@delatrie delatrie deleted the i586-suite-duplication-fix branch April 25, 2023 11:56
@suxb201
Copy link

suxb201 commented Feb 5, 2024

The default suit is three-tiered. If I only want a two-tier test suite, there's currently no way to achieve this, right? Because subSuite and parentSuite are added by default.

@delatrie delatrie mentioned this pull request Feb 20, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theme:pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 SubSuite defined while using dynamic definition (pytest)
3 participants