Add process results and attachments in parallel #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: nbdnnm <nbdnnm@gmail.com>
|
Could you please check the results on 2.22.0 release? |
Signed-off-by: nbdnnm <nbdnnm@gmail.com>
baev
added
the
type:improvement
Signed-off-by: nbdnnm <nbdnnm@gmail.com>
|
I have checked it with our reproduction case, 5200 tests, 10 fixtures per test, attaching it below so I guess it is still worth considering that repro case, run it like pytest --alluredir=allure-results test.py |
baev
requested changes
Jun 12, 2023
allure-generator/src/main/java/io/qameta/allure/core/AttachmentsPlugin.java
Outdated
Show resolved
Hide resolved
Signed-off-by: nbdnnm <nbdnnm@gmail.com>
|
@baev please review |
|
@nbdnnm The plan is to include it in the next release (I will try to land 2.23.0 sometime next week) |
baev
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related to the issue described here #1860
In our case, we use allure in pytest, and as result, we have about 2.7 GB of raw data (results+attachments) which should be generated then into a report.
There are about 15k tests, 46k attachments, 90k containers.
It takes around 50min to generate the report in the pipeline, around 30min on my mac m1.
So we dived into that and came to a quick and raw patch that gives us about 10min on mac m1.
The CPU usage jumped 10%->80%.
This PR is a proposal to discuss the approach.
@baev @eroshenkoam look forward to your feedback
Checklist