Add history trend items (fixes #362) #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baev
approved these changes
Jun 9, 2017
| .filter(ExecutorInfo.class::isInstance) | ||
| .map(ExecutorInfo.class::cast) | ||
| .collect(Collectors.toList()); | ||
| return executors.isEmpty() ? null : Collections.max(executors, |
There was a problem hiding this comment.
you can use sort together with findFirst instead and return Optional. Then use getExecutor().ifPresent(item::setExecutorInfo)
|
Also I would like to see some unit tests for that plugin |
baev
approved these changes
Jun 11, 2017
baev
changed the title
|
@sseliverstov this one is up to you |
baev
force-pushed
the
362-show-build-ids-on-trends
branch
from
efcc86b
to
0159344
Compare
sseliverstov
changed the title
just-boris
reviewed
Jun 18, 2017
| return this.options.items.map((item, i) => ({ | ||
| ...item, | ||
| id: item.buildOrder ? `build_${item.buildOrder}` : `item_${i}`, | ||
| name: item.buildOrder ? `#${item.buildOrder}` : `${this.options.items.length - i}(?)`, |
There was a problem hiding this comment.
What does this (?) at the end mean?
There was a problem hiding this comment.
If buildOrder is absent (for example in pervious format of historical data) we show index and mark it as (?)
| id: item.buildOrder ? `build_${item.buildOrder}` : `item_${i}`, | ||
| name: item.buildOrder ? `#${item.buildOrder}` : `${this.options.items.length - i}(?)`, | ||
| total: item.statistic.total, | ||
| statistic: omit(item.statistic, 'total') |
There was a problem hiding this comment.
instead of omit you can do a native thing
const {total, ...statistic} = item.statistic;| @@ -31,50 +39,100 @@ class TrendChartView extends BaseChartView { | |||
| } | |||
|
|
|||
| doShow(data) { | |||
| data = data.reverse(); | |||
There was a problem hiding this comment.
.reverse() mutates original data. Would be safer to make a copy first
data = data.slice().reverse();
just-boris
approved these changes
Jun 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)