Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-tooltips to side navigation icons #406

Merged
merged 3 commits into from
Jun 15, 2017

Conversation

leonsabr
Copy link
Contributor

Context

In collapsed state this tooltips really help for newbies. New rule: no data-tooltips in Expanded state.

tooltip

Checklist

@baev
Copy link
Member

baev commented Jun 14, 2017

@leonsabr could you please rebase and fix eslint issues:

/home/jenkins/workspace/allure2_PR-406-IVALK3T4KECVVADYDPI7Z7ECZ27P5BEPAU2C5RDQFQNKSV573WCA/allure-generator/src/main/javascript/components/side-nav/SideNavView.js
  2:24  error  'behavior' is defined but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

@leonsabr leonsabr force-pushed the add-tooltips-side-nav branch 2 times, most recently from 364ea7c to e40db8d Compare June 14, 2017 16:56
@leonsabr
Copy link
Contributor Author

I have squashed all commits.

@just-boris
Copy link
Contributor

@baev it just makes me curious, why did you remove the tooltip here: 38836f7

@leonsabr
Copy link
Contributor Author

Second commit adds translations for Expand tooltip.

@baev baev merged commit a20c308 into allure-framework:master Jun 15, 2017
@baev
Copy link
Member

baev commented Jun 15, 2017

@leonsabr thanks!

@leonsabr leonsabr deleted the add-tooltips-side-nav branch June 15, 2017 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants