Add retry messages and fix flaky (fixes #413) #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
baev
commented
Jun 15, 2017
•
baev
commented
just-boris
reviewed
Jun 15, 2017
| .withTime(retried.getTime()) | ||
| ); | ||
| latest.getStatusDetailsSafe().setFlaky(true); | ||
| latest.getStatusDetailsSafe().setFlaky(!statuses.isEmpty()); |
There was a problem hiding this comment.
Currently if a test fails 100% times, it will be displayed flaky.
It is also wrong, I think
just-boris
reviewed
Jun 15, 2017
| @@ -3,7 +3,8 @@ | |||
| {{#each retries}} | |||
| <div class="retry-row" data-uid="{{uid}}"> | |||
| <span class="label label_status_{{status}}">{{status}}</span> | |||
| {{date time.start}} at {{time time.start}} | |||
| <span>{{date time.start}} at {{time time.start}}</span> | |||
| <div class="retry__message">{{statusDetails}}</div> | |||
There was a problem hiding this comment.
if you will use <p>, then you can avoid extra styles, because <p> provides margins by default
eroshenkoam
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.