Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty results directory (fixes #312) #426

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Conversation

baev
Copy link
Member

@baev baev commented Jun 26, 2017

No description provided.

@baev baev requested a review from eroshenkoam June 26, 2017 15:07
@baev baev merged commit cf31d63 into master Jun 26, 2017
@baev baev deleted the 312-empty-results branch June 26, 2017 15:17
@baev baev removed the review label Jun 26, 2017
@just-boris
Copy link
Contributor

Actually, I used to look at this message.
It usually said me, that there were problem with adapter.
For example, integration tests in allure-mocha will pass if adapter has crashed and did not produce any result.

@just-boris
Copy link
Contributor

What is the reason on change it? It is really breaking, if you did not know.

@baev
Copy link
Member Author

baev commented Jun 26, 2017

that change is required for allure-gradle, allure-maven and other integrations in case of multi-module projects. I mean if you have a module that have no tests yet, we can not generate a report.

So for your case you will see an empty report, and that is a sign of some configuration problems.

@just-boris
Copy link
Contributor

Will you just skip the generation process at all, or generate a report with all zeroes?

@baev
Copy link
Member Author

baev commented Jun 26, 2017

we will generate empty report in case of no results found. Before this change you will get empty report anyway if your results directory exists but have no test results supported by Allure

@just-boris
Copy link
Contributor

Ok, I will follow up in allure-mocha project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants