Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug. In linux, shell=True prevents the elastix/transformix binaries from running #8

Closed
wants to merge 2 commits into from

Conversation

rcasero
Copy link

@rcasero rcasero commented Oct 12, 2017

I'm running Ubuntu zesty 64 bit, and with shell=True, the external command doesn't get called.

@rcasero
Copy link
Author

rcasero commented Oct 13, 2017

Furthermore, I'm not sure one should be using shell=True in Windows. The documentation says:

https://docs.python.org/3/library/subprocess.html

On Windows with shell=True, the COMSPEC environment variable specifies the default shell. The only time you need to specify shell=True on Windows is when the command you wish to execute is built into the shell (e.g. dir or copy). You do not need shell=True to run a batch file or console-based executable.

Note Read the Security Considerations section before using shell=True.

…ty on which one is the moving image and which one is the fixed image
@soupault
Copy link
Contributor

Included into #20 . Thanks for investigating!

@soupault soupault closed this Aug 24, 2019
@soupault soupault mentioned this pull request Sep 4, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants