Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

fixed minor issues on the timeline example overview page #1958

Merged
merged 2 commits into from
Aug 28, 2016
Merged

fixed minor issues on the timeline example overview page #1958

merged 2 commits into from
Aug 28, 2016

Conversation

mojoaxel
Copy link
Member

@mojoaxel mojoaxel commented Jul 13, 2016

fixes #1797
fixes #1937

mojoaxel and others added 2 commits July 13, 2016 14:27
* removed garbage html tags.
* removed `vis.js`and `vis.css` because there are no timeline to show on this overview.
@mojoaxel mojoaxel changed the title fixed typo in timeline example page fixed minor issues on the timeline example overview page Jul 15, 2016
@mojoaxel mojoaxel added the Docs label Aug 1, 2016
@controversial
Copy link

@mojoaxel Are you not authorized to merge even small PRs that you've created? Who else is supposed to review them?

@mojoaxel
Copy link
Member Author

I don't want to merge my own PRs without an external review. But I think in this case I can ,-)

@controversial
Copy link

Ok, cool.

On Sat, Aug 27, 2016 at 6:11 PM Alexander Wunschik notifications@github.com
wrote:

I don't want to merge my own PRs without an external review. But I think
in this case I can ,-)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1958 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJ5Yr0ifHMjMlsR2UMt-HT1zzILYMfWDks5qkLX1gaJpZM4JLXTw
.

@mojoaxel mojoaxel merged commit 2657ba1 into almende:gh-pages Aug 28, 2016
@mojoaxel
Copy link
Member Author

mojoaxel commented Aug 28, 2016

This PR broke the preview images on the timeline-examples page. 😞 (I fixed it with #2050).
@controversial That's exactly why I want reviews...

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants