This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
added code-climate checks for develop branch #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojoaxel
force-pushed
the
codeClimate
branch
2 times, most recently
from
5eae95e
to
dbb3f14
Compare
removed trailing spaces
|
So how do we use this? I'm not sure how to check out this PR |
|
@yotamberk Sorry my mistake of not being clear. You can go to the codeclimate website and see issues found by different lint-tools. |
yotamberk
approved these changes
Dec 6, 2016
|
@yotamberk Thanks! Now we can start adressing those issues: https://codeclimate.com/github/almende/vis/compare/develop |
|
I'll have to get in to it. Not sure yet the benefits. Looks cool though! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code-Climate provides a nice opportunity to get a feeling for eslint and csslint status.
I would like to integrate linting into the build process but before that we should get the major issues out of the way.
Rules that make no sense for use should be disabled.