fix: Network edges dashes isArray comparison, for inheritied styling options.
#3975
Conversation
… styling options.
| @@ -110,7 +110,9 @@ class EdgeBase { | |||
| _drawDashedLine(ctx, values, viaNode, fromPoint, toPoint) { // eslint-disable-line no-unused-vars | |||
| ctx.lineCap = 'round'; | |||
| let pattern = [5,5]; | |||
| if (Array.isArray(values.dashes) === true) { | |||
There was a problem hiding this comment.
This comparison is ONLY truthy from direct edge object property values. The inherited values from the options.edges property, somehow get converted into an array-like object, that Array.isArray does not recognize, and as shown below, when using JSON.stringify to inspect values.dashes it spits out an empty object.
|
I am also seeing this issue. Can we please get this merged @yotamberk @mojoaxel? |
|
@travomic thanks for the contribution, this looks nice. can you provide an example of this improvement in action or point us to an existing example that demonstrates the new behavior? https://github.com/almende/vis/tree/master/examples/network @austinkelleher would be cool to see an example from you as well, if you have minimal example of this handy 😄 |
This fixes being able to declare a default edge dash-array via:
edges.dashesin the options.Something in the guts of the option values converts arrays into array-like objects, that do not pass the
Array.isArraycomparison. The change in this pull-request loosens the comparison to ensure that the dashes property exists, and has.length.