make Display::dcs public, fixes #89 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really like this change. If the user can send any command to the display it is possible to leave the controller in any state and possibly break further commands that are send using the regular API. I would prefer to only expose the DCS interface as an unsafe getter, if this function is really required and there is no way to add a higher level API to achieve the same function. |
almindor
force-pushed
the
pubdcs
branch
2 times, most recently
from
446294f
to
953ecaa
Compare
|
@rfuest changed it into an |
rfuest
reviewed
Jan 13, 2024
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Display::dcsunsafemethod to allow sending custom commands. Fixes #89