Unexpected <enter> behavior #66

Closed
bistory opened this Issue Feb 28, 2011 · 3 comments

Projects

None yet

3 participants

@bistory
Member
bistory commented Feb 28, 2011

I managed to reproduce an annoying bug pointed by some of our users.
I used Firefox 3.6.13 to make it happen.

First, open the Aloha Documents example.
Put your cursor at the end of a paragraph, press enter and type a word.
Select that word, make it become a heading 1 via the floating menu, put your cursor at the end of the heading 1 and press enter.
The new line is now a heading 1 instead of a simple paragraph.

Do you have some ideas where this bug could come from ?

@npomaroli
Member

This has something to do with either the selection (how aloha editor reads the current selection) or the code which handles pressing enter.
I will modify both in near future, because it does not use the dom utility methods for dom manipulation right now, so I will recheck whether this bug still persists after I changed this.

@npomaroli npomaroli was assigned Apr 23, 2011
@npomaroli
Member

I can still reproduce this in 0.10 (even after merging all refactorings into 0.10).
I will inspect this further...

@npomaroli npomaroli added a commit that closed this issue Jul 1, 2011
@npomaroli npomaroli fix #66 - Fixed detection of pressing enter at end of a Heading: do n…
…ot consider Elements with class 'aloha-cleanme' (they are just inserted to overcome some browser rendering issues)
5c69dc6
@npomaroli npomaroli closed this in 5c69dc6 Jul 1, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment