Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dom.js #1140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dom.js #1140

wants to merge 1 commit into from

Conversation

cecilialam
Copy link
Contributor

remove formatting of Heading tags and PRE tag leave the text content with no tag. The code changes will wrap the text content with p tags. Please consider this pull request. Thanks.

@cecilialam
Update dom.js
a8c8290 
remove formatting of Heading tags and PRE tag leave the text content with no tag. The code changes will wrap the text content with p tags.
@GenticsDev
Copy link
Contributor

test

@petrosalema
Copy link
Member

@cecilialam, shouldn't we do this for any and every block-level element--not just heading and pre elements?

@cecilialam
Copy link
Contributor Author

I am not sure about all block-level elements. I would perhaps add DIV and BLOCKQUOTE to the list. It does not make sense for all block-level elements b/c there might be P tags already in those blocking tags. Nesting P tags are not legal.

@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrosalema petrosalema

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cecilialam @GenticsDev @petrosalema