Skip to content
This repository

Tabs: Properly handle documents containing <base> tag #668

wants to merge 1 commit into from

4 participants

artwist Rene Kapusta deliminator Johannes Schüth

See discussion at: jquery/jquery-ui#709

Rene Kapusta


thank you for your contribution :-)
We'll need to ask you to do two easy tasks...

Unfortunately we can only accept pull request from official contributors -- you'll just need to sign the contribution agreement (it's free -- and if you'd like to be add as contributor to the website, just send your details).
For more information see:

1) Please download our contribution agreement:

2) Fill the gaps & send a copy to (eg. scan it or make a quite good quality pic with your mobile phone)

We have also a commit checklist in place to ensure code quality and stability:



unfortunately we haven't received a contribution agreement yet.
Did you send one, or do you intend to send one?
Kind regards.

Johannes Schüth

I'll close this pull request because the contribution agreement was not signed.

Contributor Guidelines

Very important, before we can accept your code into our repository, we will need you to sign the Aloha Editor contributor license agreement (CLA). Signing the contributor's agreement does not grant anyone commit rights to the main repository, but it does mean that we can accept your contributions, and you will get an author credit if we do. Active contributors might be asked to join the core team, and given the ability to merge pull requests. In order to read and sign the CLA, please go to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Aug 12, 2012
artwist artwist Tabs: Properly handle documents containing <base> tag
See discussion at: jquery/jquery-ui#709
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. +1 1  src/plugins/common/ui/lib/tab.js
2  src/plugins/common/ui/lib/tab.js
@@ -74,7 +74,7 @@ define([
74 74 this.panels ='panels');
75 75 = 'tab-ui-container-' + (++idCounter);
76 76 this.panel = $('<div>', {id :, 'unselectable': 'on'});
77   - this.handle = $('<li><a href="#' + + '">' +
  77 + this.handle = $('<li><a href="' + document.location.href + '#' + + '">' +
78 78 settings.label + '</a></li>');
79 79
80 80 for (i = 0; i < components.length; i++) {

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.