Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: Properly handle documents containing <base> tag #668

Closed
wants to merge 1 commit into from

Conversation

artwist
Copy link

@artwist artwist commented Aug 12, 2012

See discussion at: jquery/jquery-ui#709

@evo42
Copy link
Member

evo42 commented Aug 12, 2012

Aloha!

thank you for your contribution :-)
We'll need to ask you to do two easy tasks...

Unfortunately we can only accept pull request from official contributors -- you'll just need to sign the contribution agreement (it's free -- and if you'd like to be add as contributor to the website, just send your details).
For more information see: http://aloha-editor.org/contribution.php

  1. Please download our contribution agreement:
    http://aloha-editor.org/Aloha_Editor_contribution_agreement%20_v2.pdf

  2. Fill the gaps & send a copy to office@gentics.com (eg. scan it or make a quite good quality pic with your mobile phone)

We have also a commit checklist in place to ensure code quality and stability:
https://github.com/alohaeditor/Aloha-Editor/wiki/Commit-Checklist

Mahalo,
Rene

@deliminator
Copy link
Contributor

Hello,
unfortunately we haven't received a contribution agreement yet.
Did you send one, or do you intend to send one?
Kind regards.

@Jotschi
Copy link
Contributor

Jotschi commented Sep 4, 2012

I'll close this pull request because the contribution agreement was not signed.

Contributor Guidelines

Very important, before we can accept your code into our repository, we will need you to sign the Aloha Editor contributor license agreement (CLA). Signing the contributor's agreement does not grant anyone commit rights to the main repository, but it does mean that we can accept your contributions, and you will get an author credit if we do. Active contributors might be asked to join the core team, and given the ability to merge pull requests. In order to read and sign the CLA, please go to:

http://aloha-editor.org/contribution.php

@Jotschi Jotschi closed this Sep 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants