Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop the dependency on knesset-data-datapackage #1

Merged
merged 3 commits into from
Jul 8, 2017

Conversation

OriHoch
Copy link

@OriHoch OriHoch commented Jul 8, 2017

suggested changes to PR hasadna#9:

  • dropped the dependency on knesset-data-datapackage
    • this over complicated things
    • support scraping only from a pre-created datapackage zip file
    • use the datapackage schema json file to determine field types
  • skipped the datapackage test
    • it was very fragile, need to think how to make it less fragile

@OriHoch
Copy link
Author

OriHoch commented Jul 8, 2017

@OriHoch
Copy link
Author

OriHoch commented Jul 8, 2017

@alonisser alonisser merged commit baf896e into alonisser:master Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants