Fix checkbox and switch position on long texts on M2 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alorma
approved these changes
May 9, 2023
|
Thanks @NKJe |
ZacSweers
pushed a commit
to ZacSweers/CatchUp
that referenced
this pull request
May 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.github.alorma:compose-settings-storage-datastore](https://togithub.com/alorma/Compose-Settings) | `0.26.0` -> `0.27.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.github.alorma:compose-settings-ui-m3](https://togithub.com/alorma/Compose-Settings) | `0.26.0` -> `0.27.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>alorma/Compose-Settings</summary> ### [`v0.27.0`](https://togithub.com/alorma/Compose-Settings/releases/tag/0.27.0) [Compare Source](https://togithub.com/alorma/Compose-Settings/compare/0.26.0...0.27.0) ##### What's Changed - Bump androidx.compose:compose-bom from 2023.04.00 to 2023.04.01 by [@​dependabot](https://togithub.com/dependabot) in [alorma/Compose-Settings#139 - Bump androidx.activity:activity-compose from 1.7.0 to 1.7.1 by [@​dependabot](https://togithub.com/dependabot) in [alorma/Compose-Settings#140 - Bump androidx.compose:compose-bom from 2023.04.01 to 2023.05.00 by [@​dependabot](https://togithub.com/dependabot) in [alorma/Compose-Settings#143 - Fix checkbox and switch position on long texts on M2 by [@​NKJe](https://togithub.com/NKJe) in [alorma/Compose-Settings#146 ##### New Contributors - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [alorma/Compose-Settings#139 - [@​NKJe](https://togithub.com/NKJe) made their first contribution in [alorma/Compose-Settings#146 **Full Changelog**: alorma/Compose-Settings@0.26.0...0.27.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ZacSweers/CatchUp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43NC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzQuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix positions of switches and on long text on M2. Removed the Spacer and moved the weight to the SettingsTileTexts element. This ensures that the icon and switch/checkbox is measured first. It'll still fill the remaining space. Also fixed an unused Modifier on SettingsTileTexts.
Swiches before:
Switches after:
Checkboxes before:
Checkboxes after: