Enable debug assertions in XMMatrixReflect and XMMatrixShadow

aloucks · Oct 18, 2020 · 90ef04c · 90ef04c
1 parent a719608
commit 90ef04c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Fixed
+- Enable `!XMPlaneIsInfinite` debug assertions in `XMMatrixReflect` and `XMMatrixShadow`.
 
 ## [0.2.0] - 2020-09-05
 ### Fixed

diff --git a/src/matrix.rs b/src/matrix.rs
@@ -2599,8 +2599,7 @@ pub fn XMMatrixReflect(
 {
     unsafe {
         debug_assert!(!XMVector3Equal(ReflectionPlane, XMVectorZero()));
-        // FIXME: XMPlaneIsInfinite
-        // debug_assert!(!XMPlaneIsInfinite(ReflectionPlane));
+        debug_assert!(!XMPlaneIsInfinite(ReflectionPlane));
 
         const NegativeTwo: XMVECTORF32 = XMVECTORF32 { f: [ -2.0, -2.0, -2.0, 0.0 ] };
 
@@ -2651,8 +2650,7 @@ pub fn XMMatrixShadow(
         const Select0001: XMVECTORU32 = XMVECTORU32 { u: [ XM_SELECT_0, XM_SELECT_0, XM_SELECT_0, XM_SELECT_1 ] };
 
         debug_assert!(!XMVector3Equal(ShadowPlane, XMVectorZero()));
-        // FIXME: XMPlaneIsInfinite
-        // debug_assert!(!XMPlaneIsInfinite(ShadowPlane));
+        debug_assert!(!XMPlaneIsInfinite(ShadowPlane));
 
         let mut P: XMVECTOR = XMPlaneNormalize(ShadowPlane);
         let mut Dot: XMVECTOR = XMPlaneDot(P, LightPosition);