Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace trading_calendars with exchange_calendars #178

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

Tantalon
Copy link
Contributor

fix for #176

trading_calendars is broken and unmaintained.
exchange_calendars is a maintained fork that's recommended by trading_calendars and has fixed this issue.
This PR changes from trading_calendars to exchange_calendars to resolve #176.

@problemss
Copy link

Was this ever fixed in the main branch? I am still seeing this error.

@shinhwas
Copy link

shinhwas commented Nov 8, 2021

I have same problem with below version
alpaca-trade-api==1.2.3
alpaca-backtrader-api == 0.14.1

@jllovet
Copy link

jllovet commented Dec 13, 2021

Plus one to merge this PR. Still seeing this issue.

jllovet added a commit to jllovet/alpaca-backtrader-api that referenced this pull request Dec 13, 2021
@haxdds haxdds merged commit 1b537ac into alpacahq:master Dec 21, 2021
@Tantalon Tantalon deleted the fix/trading_calendars_broken branch December 21, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean install fails - trading_calendars is broken and unmaintained
6 participants