Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(xignite): remove unnecessary comments and files #531

Merged
merged 3 commits into from Dec 16, 2021

Conversation

dakimura
Copy link
Contributor

@dakimura dakimura commented Dec 16, 2021

WHAT

  • remove unnecessary comment like //-------
  • change level of the log shown when ListIndexSymbols API fails from WARN to ERROR
  • add Info log before calling GetRealTimeQuotes API

WHY

  • refactor

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

Merging #531 (07d86ef) into master (0f59ea9) will decrease coverage by 0.08%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   48.05%   47.96%   -0.09%     
==========================================
  Files         125      125              
  Lines       12375    12375              
==========================================
- Hits         5947     5936      -11     
- Misses       5931     5942      +11     
  Partials      497      497              
Impacted Files Coverage Δ
contrib/xignitefeeder/api/model.go 0.00% <ø> (ø)
contrib/xignitefeeder/configs/config.go 49.23% <ø> (ø)
contrib/xignitefeeder/symbols/manager.go 23.25% <0.00%> (ø)
contrib/xignitefeeder/writer/quotes_writer.go 92.85% <ø> (ø)
contrib/xignitefeeder/api/client.go 61.15% <100.00%> (ø)
frontend/stream/stream.go 58.97% <0.00%> (-12.83%) ⬇️
metrics/du.go 90.90% <0.00%> (+18.18%) ⬆️

@dakimura dakimura merged commit f7ff46c into master Dec 16, 2021
@dakimura dakimura deleted the xignite/refactor branch December 16, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants