redeclare examples as integration tests #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminW3
force-pushed
the
topic-tests
branch
5 times, most recently
from
c081833
to
3a48ff6
Compare
BenjaminW3
force-pushed
the
topic-tests
branch
18 times, most recently
from
dfe5eb7
to
4acdeae
Compare
|
I have additionally added a vector addition single file example without additional includes using a single accelerator and without time measurement. |
|
Could you please split this pull request one for move examples to integration tests and one for the first easy example. It is easier to review. |
| { | ||
| // Calculate the number of elements to compute in this thread. | ||
| // The result is uniform for all but the last thread. | ||
| auto const elems(threadElemExtent + alpaka::math::min(acc, static_cast<unsigned long long>(0u), static_cast<unsigned long long>(numElements-(threadFirstElemIdx+threadElemExtent)))); |
There was a problem hiding this comment.
independent of the point that we should move this in a separate pull request:
Might be we should create a alpaka trait/function for this line.
BenjaminW3
force-pushed
the
topic-tests
branch
from
4acdeae
to
5fb7e17
Compare
|
The request has been split. |
BenjaminW3
force-pushed
the
topic-tests
branch
from
5fb7e17
to
ce9ea1d
Compare
| eval "${2}" | ||
| fi | ||
|
|
||
| cd "${oldPath}" |
There was a problem hiding this comment.
missing end of file newline
|
after the missing EOF is added I can merge this pull request |
BenjaminW3
force-pushed
the
topic-tests
branch
from
ce9ea1d
to
6140cc8
Compare
psychocoderHPC
added a commit
that referenced
this pull request
Nov 6, 2015
redeclare examples as integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As has been noted in #77 the current examples are not really easy examples but represent more or less integration tests. Therefore they have been moved to
test/integ.