Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: String-typed ConstantTerms for strings and constant symbols mistakenly equal (Issue #244) #245

Merged
merged 5 commits into from
Apr 3, 2020

Conversation

madmike200590
Copy link
Collaborator

Fixes the bug described in issue #244

@madmike200590 madmike200590 changed the title Bugfix: String-typed ConstantTerms for strings and constant symbols mistakenly equal (Issue#244)) Bugfix: String-typed ConstantTerms for strings and constant symbols mistakenly equal (Issue#244) Apr 3, 2020
@madmike200590 madmike200590 changed the title Bugfix: String-typed ConstantTerms for strings and constant symbols mistakenly equal (Issue#244) Bugfix: String-typed ConstantTerms for strings and constant symbols mistakenly equal (Issue #244) Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #245 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #245      +/-   ##
============================================
+ Coverage     76.79%   76.82%   +0.02%     
- Complexity     2052     2055       +3     
============================================
  Files           150      150              
  Lines          6780     6782       +2     
  Branches       1183     1184       +1     
============================================
+ Hits           5207     5210       +3     
  Misses         1177     1177              
+ Partials        396      395       -1
Impacted Files Coverage Δ Complexity Δ
.../ac/tuwien/kr/alpha/common/terms/ConstantTerm.java 95.83% <100%> (+2.35%) 29 <0> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225fa87...fcfca33. Read the comment docs.

@AntoniusW AntoniusW merged commit 2239eb3 into master Apr 3, 2020
@AntoniusW AntoniusW deleted the bugfix_term_equality branch April 3, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String-typed ConstantTerms for strings and constant symbols mistakenly equal
2 participants