Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed prefix of input union types #455

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented May 16, 2024

This commit fixes two problems:

  • The extend built-in method of the List was used, but a return value was attended. However, the extend method operates in-place.
  • When a prefix is present in an input that has union types, the prefix was duplicated several times, e.g. --input --input DATA. The CWL inputBinding definition used to be evaluated both in the internal CWLCommandToken objects of the CWLUnionCommandToken, and in an external CWLCommandToken wrapping the CWLUnionCommandToken. Now, the external CWLCommandToken is not created and it is used the CWLUnionCommandToken directly.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.14%. Comparing base (244de3b) to head (958b5b2).
Report is 4 commits behind head on master.

Files Patch % Lines
streamflow/cwl/command.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   70.18%   70.14%   -0.04%     
==========================================
  Files          83       83              
  Lines       10587    10591       +4     
  Branches     2505     2508       +3     
==========================================
- Hits         7430     7429       -1     
- Misses       2702     2703       +1     
- Partials      455      459       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanderOtto LanderOtto changed the title Fixed input union types Fixed prefix of input union types May 16, 2024
@GlassOfWhiskey GlassOfWhiskey merged commit 51eb6ad into master May 18, 2024
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the fix/multiple-input-types branch May 18, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants