Update Node version #324
Merged
Update Node version #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with Fiber 3.0 which requires node 8+. It was updated as part of this commit: a27dcdf I think it wasn't picked up because of the following two reason: - the contributor may not have realised that their local node version was not using node 6.9.1 and - Travis CI tests using LTS This commit also changes the version Travis CI uses by using the version in .nvmrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem while trying to install it locally for development. It turned out to be an issue with Fiber 3.0 not supporting Node 6.9.1
Fiber 3.0 requires node 8+ https://www.npmjs.com/package/fibers#supported-platforms. It was updated as part of this commit: a27dcdf
I think it wasn't picked up because of the following two reason:
was not using node 6.9.1 and
This commit also changes the version Travis CI uses by using the version
in .nvmrc