-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to WebdriverIO v8 #615
Conversation
a119c39
to
f0db0fe
Compare
d5f0307
to
f5d9a08
Compare
f0db0fe
to
267ed78
Compare
f5d9a08
to
e8d3ecb
Compare
267ed78
to
b335388
Compare
254d8ce
to
7143518
Compare
b335388
to
06307ca
Compare
7143518
to
9a0e75a
Compare
9a0e75a
to
5d96556
Compare
f4516b4
to
a45c36a
Compare
5d96556
to
071fb84
Compare
90900ca
to
f0f41d3
Compare
071fb84
to
9ba084c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update's looking good 🙌🏻 Thinking we can buy into WebDriver a little more if we use it for expecations, and that we may need a little update (either code or comment) around the setup of Sauce Service 😊
e9a4bdd
to
ff3f5a6
Compare
8b23a02
to
984bda6
Compare
I've temporarily rolled back to |
23150f7
to
52f81f5
Compare
@romaricpascal Ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's green again! Thanks for looking at what needed to be pinned ⛵
52f81f5
to
542b077
Compare
Let's merge this and let Dependabot pick up updates once webdriverio/webdriverio@f4f924b is released |
Upgrades to WebdriverIO v8 from v7
There were some regressions in IE11 and Firefox 55, including:
TypeError: invalid 'instanceof' operand window.ShadowRoot
in Firefox 55 + IE11 webdriverio/webdriverio#11705.contains()
crash IE11 viaisElementDisplayed()
webdriverio/webdriverio#11711Array.from()
errors in older browsers viaisElementDisplayed()
webdriverio/webdriverio#11716But these are now resolved
Package audit
See results from
npm audit
belowfound 0 vulnerabilities