Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to WebdriverIO v8 #615

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Upgrade to WebdriverIO v8 #615

merged 2 commits into from
Jan 16, 2024

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Nov 21, 2023

@colinrotherham colinrotherham added the dependencies Pull requests that update a dependency file label Nov 21, 2023
@colinrotherham colinrotherham force-pushed the package-updates-webdriverio branch 8 times, most recently from 254d8ce to 7143518 Compare November 24, 2023 10:34
@colinrotherham colinrotherham marked this pull request as ready for review November 27, 2023 10:06
@colinrotherham colinrotherham changed the title [WIP] Upgrade to WebdriverIO v8 Upgrade to WebdriverIO v8 Nov 27, 2023
@colinrotherham colinrotherham self-assigned this Dec 4, 2023
@colinrotherham colinrotherham changed the base branch from package-updates to package-updates-webpack January 9, 2024 19:13
@romaricpascal romaricpascal added this to the Next milestone Jan 11, 2024
@romaricpascal romaricpascal force-pushed the package-updates-webpack branch 2 times, most recently from 90900ca to f0f41d3 Compare January 15, 2024 12:15
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update's looking good 🙌🏻 Thinking we can buy into WebDriver a little more if we use it for expecations, and that we may need a little update (either code or comment) around the setup of Sauce Service 😊

test/integration/index.js Show resolved Hide resolved
test/wdio.config.js Outdated Show resolved Hide resolved
@colinrotherham colinrotherham force-pushed the package-updates-webpack branch 2 times, most recently from e9a4bdd to ff3f5a6 Compare January 16, 2024 11:22
@colinrotherham colinrotherham force-pushed the package-updates-webdriverio branch 2 times, most recently from 8b23a02 to 984bda6 Compare January 16, 2024 11:41
@colinrotherham
Copy link
Contributor Author

I've temporarily rolled back to webdriverio@8.27.0 since an IE11 fix of ours was accidentally reverted:

@colinrotherham colinrotherham force-pushed the package-updates-webdriverio branch 2 times, most recently from 23150f7 to 52f81f5 Compare January 16, 2024 13:36
@colinrotherham
Copy link
Contributor Author

@romaricpascal Ready for review again

Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's green again! Thanks for looking at what needed to be pinned ⛵

Base automatically changed from package-updates-webpack to main January 16, 2024 16:14
@colinrotherham
Copy link
Contributor Author

Let's merge this and let Dependabot pick up updates once webdriverio/webdriverio@f4f924b is released

@colinrotherham colinrotherham merged commit 3e04906 into main Jan 16, 2024
3 checks passed
@colinrotherham colinrotherham deleted the package-updates-webdriverio branch January 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants