This repository has been archived by the owner on Mar 24, 2021. It is now read-only.
Add ability to specify different collection methods #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be more explicit about what it actually is.
Previously, any leftover fields were passed to the result record which was misleading. Now we don't include unspecified fields in the result.
Methods are passed in to a collect query param as field:method.
|
If you try to collect a string property with "sum", you get the error message: "Cannot collect an invalid field name". It would be nicer to have an error message explaining the real problem. |
|
If the query is using collect=field:set, would it make sense to include only the property field:set in the response? I don't think we need to keep the backwards compatible option if the request is using the new syntax. |
|
Also, you have changed the readme, but there is no mention of the new feature. Should there be some documentation for it? Actually the readme may not be the ideal place for detailed documentation about the api, but in this case we should write something else, a page in the wiki for example. |
If you request field:set, you should only receive field:set in the response, not field as well.
When you request a collect sum on a string (or similar), you should receive a 400 bad request.
It is causing CI to fail every time. It seems to be an issue in selenium. https://code.google.com/p/selenium/issues/detail?id=3812
All the ways of running tests should act the same way. I would like to have this done in just one place but I don't want to hold up this pull request any more.
Merged
|
👍 |
alexmuller
added a commit
that referenced
this pull request
Jul 5, 2013
Add ability to specify different collection methods
alexmuller
added a commit
that referenced
this pull request
Aug 23, 2013
Add ability to specify different collection methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Pivotal [#52056357], "Add functionality to backdrop to sum items"
This change adds an option to the collect parameter, so that you can ask for
?collect=field:sum(and a few other methods).(Rob says: we've got some query code in
database.pythat shouldn't be there. Can be refactored later.)