This repository has been archived by the owner on Mar 24, 2021. It is now read-only.
Refactor run tests #114
Merged
Refactor run tests #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In development run `./run_tests.sh` - `jenkins.sh` uses `./run_tests.sh` - `.travis` uses `./run_tests.sh` Simples! This assumes that you're using virtualenvwrapper in development (or at least have your `WORKON_HOME` environment variable set). If you're not then you will need to be in a virtualenv before executing `./run_tests.sh`
| display_result $? 1 "Unit tests" | ||
|
|
||
| behave --stop --tags=-wip | ||
| display_result $? 2 "Feature tests" | ||
|
|
||
| "$basedir/pep-it.sh" | ||
| ./pep-it.sh | tee pep8.out |
There was a problem hiding this comment.
This lines with piped commands requires that the script sets the pipefail option:
set -o pipefail
Otherwise the variable $? always holds the exit status of the last command, which means a failure of pep-it.sh would be ignored.
|
👍 We have duplicates of these scripts in all of out python projects. As a further improvement, we could extract these in something reusable by multiple projects, like a pip package. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./run_tests.shjenkins.shuses./run_tests.sh.travisuses./run_tests.shSimples!
This assumes that you're using virtualenvwrapper in development (or at least have your
WORKON_HOMEenvironment variable set). If you're not then you will need to be in a virtualenv before executing./run_tests.shThis depends on #113