This repository has been archived by the owner on Mar 24, 2021. It is now read-only.
Serialize dev startup #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| waiting=0 | ||
| until mkdir $LOCK_DIR > /dev/null 2>&1; do | ||
| if [ $waiting -eq 0 ]; then | ||
| echo "waiting for startup lock" |
There was a problem hiding this comment.
Is indentation 4 spaces or 2?
Adds a lock directory that must be held before the virtualenv can be created and dependencies installed. This prevents a concurrency bug where if dependencies are installed for multiple virtualenvs at the same time they can hang.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lock directory that must be held before the virtualenv can be
created and dependencies installed. This prevents a concurrency bug
where if dependencies are installed for multiple virtualenvs at the same
time they can hang.