This repository has been archived by the owner on Mar 24, 2021. It is now read-only.
Stagecraft integration #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't store the metadata in Backdrop any more. We're modifying BucketConfigRepository to call the Stagecraft /data-sets endpoint to get the metadata.
Backdrop now gets its config from Stagecraft rather than storing it itself. We need a fake Stagecraft server to return config for feature tests where we cannot stub out the Stagecraft client interface.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this code the BucketConfigRepository now calls Stagecraft's /data-sets endpoint to get the metadata for Data Sets. Many changes had to be made to the tests in order for them to work with this.