Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort documents in the "services" and "guidance & regulation" supergroups by popularity descending #1095

Merged
merged 3 commits into from Apr 25, 2019
Merged

Sort documents in the "services" and "guidance & regulation" supergroups by popularity descending #1095

merged 3 commits into from Apr 25, 2019

Conversation

barrucadu
Copy link
Contributor

@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 11:36 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 11:39 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 11:45 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 11:51 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 11:56 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 12:05 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 12:10 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 12:16 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 12:27 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 12:43 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 13:05 Inactive
@benthorner benthorner temporarily deployed to govuk-collections-pr-1095 April 24, 2019 13:12 Inactive
@barrucadu barrucadu marked this pull request as ready for review April 24, 2019 13:19
sihugh
sihugh approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@sihugh sihugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick on the @, otherwise 👍

app/services/search/supergroup.rb Outdated Show resolved Hide resolved
@barrucadu barrucadu merged commit 81d0fb9 into master Apr 25, 2019
@barrucadu barrucadu deleted the msw/sort-supergroups branch April 25, 2019 10:52
@barrucadu barrucadu mentioned this pull request May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sihugh sihugh sihugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barrucadu @sihugh @benthorner