Ensure user chooses supertype / document type #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/EDDD2DYl/128-handle-when-the-user-doesnt-select-a-supertype-or-document-type
This prevents the user reaching an error page in the case where they
forget to choose a supertype or a document type, and then click the
'Continue' button when creating a document.
The page to choose a document type was previously a POST route, which
made it awkward to re-visit the page if the user doesn't select a
document type and clicks 'Continue'. To support re-visiting the page,
the route is now a GET route and the form_tag for choosing a supertype
now has the explicit route to get to it, turning off the UTF8 character
set param to keep the resulting URL query params clean.
Note that there's still a spurious 'button' query param, which is added by the
form submit button. There's a separate PR to fix this: alphagov/govuk_publishing_components#479.