Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added accessibility statement and amended config file to show the page in the docs #59

Merged
merged 4 commits into from
Sep 21, 2020

Conversation

PippaClarkGDS
Copy link

PR to add the accessibility statement to these docs to comply with legal instructions.

To review: check this page renders correctly as Middleman was not working to confirm the page was loading right.

@jonathanglassman
Copy link
Contributor

@PippaClarkGDS i've checked locally and the statement link doesn't work. The message comes up "File Not Found
/accessibility-statement". I think you need to add a .html to the footer link. So data.gov.uk Technical Documentation Accessibility: /accessibility-statement becomes data.gov.uk Technical Documentation Accessibility: /accessibility-statement.html

@jonathanglassman
Copy link
Contributor

@PippaClarkGDS have tested this locally and confirm that adding .html works

@PippaClarkGDS
Copy link
Author

Thanks @jonathanglassman. Have added a commit to fix this - does that work ok?

@jonathanglassman
Copy link
Contributor

Thanks @jonathanglassman. Have added a commit to fix this - does that work ok?

pulled in your change, checked, and it works

@PippaClarkGDS
Copy link
Author

Thanks @jonathanglassman. Have added a commit to fix this - does that work ok?

pulled in your change, checked, and it works

Cheers @jonathanglassman - good to know it works. Will wait for tech lead to approve and merge.

Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋 I'm covering for Ken at the moment. Have given this a technical review, nothing major except for the missing [EASS] definition, if you could take a look?

source/accessibility-statement.html.md.erb Show resolved Hide resolved
source/accessibility-statement.html.md.erb Outdated Show resolved Hide resolved
source/accessibility-statement.html.md.erb Outdated Show resolved Hide resolved
source/accessibility-statement.html.md.erb Show resolved Hide resolved
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now - thanks! Will merge now and deploy today/tomorrow. I'll update with a comment in this PR once it has been deployed 👍

@ChrisBAshton ChrisBAshton merged commit 82b715c into master Sep 21, 2020
@ChrisBAshton ChrisBAshton deleted the add-accessibility-statement branch September 21, 2020 13:47
@ChrisBAshton
Copy link
Contributor

That's live now @PippaClarkGDS 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants