Fix encoding exceptions #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like Android 6.0.1 in some circumstances is sending the tick mark that Rails uses to force UTF-8 encoding as a raw character and not as %HH encoded values as it's meant to according to the RFC. The tick mark doesn't give us any benefit for the search forms so it's safe to turn if off and it just pollutes the URL anyway.
We don't need the value for the submit button in the form params so by removing the name we will force the browser not to send it and reduce visual noise in the search urls.
Sometimes the url returned by Rack is encoded as binary due to clients not properly encoding urls. When this url was being output as a url tag in the Open Graph meta tags it was causing the transformation of the output buffer from UTF-8 to binary and causing later concatenations to blow up with an incompatible character encodings exception.
Sometime the url is returned as binary by Rack because it hasn't been encoded properly by the client so force encoding it to UTF-8 will stop incompatible encoding errors creeping in elsewhere.
alanth
approved these changes
Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes clients aren't properly encoding UTF-8 chars as %HH chars in the request url and this was causing exceptions further down the stack. The primary source of the UTF-8 chars is the tick mark introduced in Rails 3 to force UTF-8 encoding in form submissions from IE. Since this isn't relevant anymore we can just disable the tick mark but we should also force UTF-8 encoding on the url anyway because there were other sources (mostly old links to search pages).