Remove specialist topics from email-alert-service #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
We've got some questions related to this PR, so those need to be answered first before it's merged, so I've marked it as "do not merge" until those are answered. More info in the comments in the linked ticket. |
Tetrino
approved these changes
Apr 15, 2024
hannako
requested changes
May 8, 2024
unoduetre
force-pushed
the
2497-remove-specialist-topics-from-email-alert-service-s-m
branch
4 times, most recently
from
01fb2db
to
bd20c3a
Compare
unoduetre
force-pushed
the
2497-remove-specialist-topics-from-email-alert-service-s-m
branch
from
bd20c3a
to
181dc33
Compare
unoduetre
deleted the
2497-remove-specialist-topics-from-email-alert-service-s-m
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove specialist topics from the supported attributes in email-alert-service.
Please investigate and make a note on the PR about what the `:topic` field is referring to here: https://github.com/alphagov/email-alert-service/blob/53ce12e4ea8f5643dbb3051c8ec5c9651afa8b6b/lib/tasks/message_queues.rake#L10C45-L10C51
Why
Retiring specialist topics.
Trello card