Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose "A specific page" option more often #154

Merged
merged 1 commit into from Jul 10, 2015
Merged

Choose "A specific page" option more often #154

merged 1 commit into from Jul 10, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 9, 2015

Whenever there’s a specific page value that we’ve saved and prepopulated, default to “specific page” feedback type.

Follow on from #153, fixes #153 (comment):

One design question: with this implementation, the specific page name is pre-populated but not selected in the feedback form. Unless the user actively selects the "a specific page" option, the URL won't make it through to the ticket. Should the "a specific page" be selected by default, or alternatively should the path be added to the form as a hidden parameter and then passed through into Zendesk?

cc @benilovj

Whenever there’s a specific page value that we’ve saved and
prepopulated, default to “specific page” feedback type.
@benilovj
Copy link
Contributor

@benilovj benilovj commented Jul 9, 2015

👍

fofr added a commit that referenced this pull request Jul 10, 2015
Choose "A specific page" option more often
@fofr fofr merged commit 96c8459 into master Jul 10, 2015
1 check passed
1 check passed
default "Build #82 succeeded on Jenkins"
Details
@fofr fofr deleted the default-specific-page branch Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.