Don't facet on things that will be ignored #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihugh
changed the title
sihugh
force-pushed
the
track-facets-part-2
branch
from
94dc97f
to
574d2e5
Compare
sihugh
force-pushed
the
track-facets-part-2
branch
from
574d2e5
to
eae7f38
Compare
Faceting on things that are populated from local registries just adds load to the system for no benefit. On a search from https://www.gov.uk/search/all we go from a query like: https://www.gov.uk/api/search.json?count=20&start=0&fields=title%2Clink%2Cdescription%2Cpublic_timestamp%2Cpopularity%2Ccontent_purpose_supergroup%2Cformat%2Cpart_of_taxonomy_tree%2Cmanual%2Corganisations%2Cpeople%2Cworld_locations&q=government&reject_link[]=%2Fsearch%2Fall&facet_manual=1500%2Corder%3Avalue.title&facet_organisations=1500%2Corder%3Avalue.title&facet_people=1500%2Corder%3Avalue.title&facet_world_locations=1500%2Corder%3Avalue.title&filter_all_part_of_taxonomy_tree[]&filter_all_part_of_taxonomy_tree[] to https://www.gov.uk/api/search.json?count=20&start=0&fields=title%2Clink%2Cdescription%2Cpublic_timestamp%2Cpopularity%2Ccontent_purpose_supergroup%2Cformat%2Cpart_of_taxonomy_tree%2Cmanual%2Corganisations%2Cpeople%2Cworld_locations&q=government&reject_link[]=%2Fsearch%2Fall&filter_all_part_of_taxonomy_tree[]&filter_all_part_of_taxonomy_tree[] which is a reduction in payload from 559kb to 29.5kb, and in response time from ~650ms to ~250ms (cold) and from ~200ms to ~25ms (warm - ie submitting the same query). I've added some registry stubs to feature tests because we were somehow not using these before. I'm all for dynamic faceting, but we should only use it when it's useful.
sihugh
force-pushed
the
track-facets-part-2
branch
from
eae7f38
to
c302bd7
Compare
sihugh
changed the title
bilbof
reviewed
Jun 7, 2019
|
Thanks Bill! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggy backs off #1172
Faceting on things that are populated from local registries just adds load to the system for no benefit.
On a search from https://www.gov.uk/search/all we go from a query like:
https://www.gov.uk/api/search.json?count=20&start=0&fields=title%2Clink%2Cdescription%2Cpublic_timestamp%2Cpopularity%2Ccontent_purpose_supergroup%2Cformat%2Cpart_of_taxonomy_tree%2Cmanual%2Corganisations%2Cpeople%2Cworld_locations&q=government&reject_link[]=%2Fsearch%2Fall&facet_manual=1500%2Corder%3Avalue.title&facet_organisations=1500%2Corder%3Avalue.title&facet_people=1500%2Corder%3Avalue.title&facet_world_locations=1500%2Corder%3Avalue.title&filter_all_part_of_taxonomy_tree[]&filter_all_part_of_taxonomy_tree[]
to
https://www.gov.uk/api/search.json?count=20&start=0&fields=title%2Clink%2Cdescription%2Cpublic_timestamp%2Cpopularity%2Ccontent_purpose_supergroup%2Cformat%2Cpart_of_taxonomy_tree%2Cmanual%2Corganisations%2Cpeople%2Cworld_locations&q=government&reject_link[]=%2Fsearch%2Fall&filter_all_part_of_taxonomy_tree[]&filter_all_part_of_taxonomy_tree[]
which is a reduction in response payload from 559kb to 29.5kb, and in response time
from ~650ms to ~250ms (cold) and from ~200ms to ~25ms (warm - ie submitting
the same query to search-api again).
I deployed this to staging for a test - the initial low period is because traffic replay was not hitting finder frontend.
The high spike is current master, and the low part afterwards is the improvement due to this PR being deployed.
I'm all for dynamic faceting, but we should only use it when it's useful.
Search page examples to sanity check:
Other finders