Upgrade to Rails 6 #1709
Merged
Upgrade to Rails 6 #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrucadu
force-pushed
the
msw/rails-6
branch
from
1342b28
to
43ee2b3
Compare
sihugh
reviewed
Nov 4, 2019
barrucadu
force-pushed
the
msw/rails-6
branch
from
00b08c3
to
1631a68
Compare
barrucadu
force-pushed
the
msw/rails-6
branch
from
1631a68
to
5a32942
Compare
sihugh
reviewed
Nov 5, 2019
barrucadu
force-pushed
the
msw/rails-6
branch
from
6aa0a2e
to
77b456f
Compare
bilbof
approved these changes
Nov 5, 2019
|
Another Gemfile conflict! 😱 |
Using a beta version of rspec-rails due to an upstream bug: we should switch to 4.0.0 when that's out.
This wasn't covered by the app:update task because this is a custom initialiser.
This fixes a potential RCE exception, though the app doesn't set cookies.
We can re-enable this when libsass adds support for min/max.
The app fails to start in govuk-docker without this:
/[etc]/activesupport-6.0.0/lib/active_support/dependencies.rb:325:
in `require': Could not load the 'listen' gem. Add `gem 'listen'`
to the development group of your Gemfile (LoadError)
barrucadu
force-pushed
the
msw/rails-6
branch
from
77b456f
to
b5d3042
Compare
bilbof
approved these changes
Nov 6, 2019
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should gradually switch to the new defaults once we're happy with this.
There's one deprecation warning which bothers me:
But... according to
git grep parent_name, it's not referenced anywhere. Must be in a dependency, in which case hopefully it'll be updated before then.Trello card
Search page examples to sanity check:
Other finders