Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Heroku review apps #311

Merged
merged 2 commits into from Sep 27, 2017
Merged

Enable Heroku review apps #311

merged 2 commits into from Sep 27, 2017

Commits on Sep 26, 2017

  1. Enable Heroku review apps

    Apps will be available at:
    https://finder-frontend.herokuapp.com
    https://finder-frontend-pr-XXX.herokuapp.com
    
    Heroku needs to read ruby version from Gemfile
    fofr committed Sep 26, 2017
    Copy the full SHA
    a23974c View commit details
    Browse the repository at this point in the history
  2. Include mustache precompile step for Heroku

    * Shim the precompile task into the assets:precompile step that Heroku
    automatically runs
    * The equivalent of
    https://github.com/alphagov/govuk-app-deployment/blob/b13ba1ae8be0e0a302
    aaacd4990b86f02b422241/finder-frontend/config/deploy.rb#L18-L20
    * Running the task after deployment means the generated file gets
    cleaned up by Heroku’s ephemeral file system
    fofr committed Sep 26, 2017
    Copy the full SHA
    0dfc3c8 View commit details
    Browse the repository at this point in the history