Remove qa feature flag #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevanloon
force-pushed
the
remove-qa-feature-flag
branch
from
b4960fc
to
f2c6b39
Compare
rubenarakelyan
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
We should also remove https://github.com/alphagov/govuk-puppet/blob/c7ace591b6088545742645659f0216e4c66e7eb9/modules/govuk/manifests/apps/finder_frontend.pp#L69-L75, https://github.com/alphagov/govuk-puppet/blob/c7ace591b6088545742645659f0216e4c66e7eb9/modules/govuk/manifests/apps/finder_frontend.pp#L38 and https://github.com/alphagov/govuk-puppet/blob/c7ace591b6088545742645659f0216e4c66e7eb9/hieradata_aws/integration.yaml#L32.
bevanloon
force-pushed
the
remove-qa-feature-flag
branch
2 times, most recently
from
bb5b492
to
09a7bdf
Compare
thomasleese
approved these changes
Dec 19, 2018
edwardkerry
approved these changes
Dec 19, 2018
bevanloon
force-pushed
the
remove-qa-feature-flag
branch
from
7a6fb41
to
b65f8b3
Compare
bevanloon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding:
Extra commit to streamline the deploy process - supersedes #728