Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove qa feature flag #727

Merged
merged 2 commits into from Dec 19, 2018
Merged

Remove qa feature flag #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4e2546
Remove qa feature flag
Dec 10, 2018
b65f8b3
Remove qa to content feature flag
Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/controllers/qa_controller.rb
View file
Open in desktop
Expand Up @@ -5,8 +5,6 @@ class QaController < ApplicationController
include GdsApi::Helpers

def show
return error_not_found unless ENV["FINDER_FRONTEND_ENABLE_QA"]

redirect_to_finder if finder_page?
raw_finder
end
Expand Down
2 changes: 0 additions & 2 deletions app/controllers/qa_to_content_controller.rb
View file
Open in desktop
Expand Up @@ -8,8 +8,6 @@ class QaToContentController < ApplicationController
include GdsApi::Helpers

def show
return error_not_found unless ENV["FINDER_FRONTEND_ENABLE_QA_TO_CONTENT"]

return redirect_to content_url if redirect_to_content?

render "qa_to_content/show"
Expand Down
4 changes: 0 additions & 4 deletions features/support/env.rb
View file
Open in desktop
Expand Up @@ -61,7 +61,3 @@
# The :transaction strategy is faster, but might give you threading problems.
# See https://github.com/cucumber/cucumber-rails/blob/master/features/choose_javascript_database_strategy.feature
Cucumber::Rails::Database.javascript_strategy = :truncation

ENV["FINDER_FRONTEND_ENABLE_QA"] = 'true'
# A temporary environment variable acting as a feature flag. This can be removed when the corresponding
# 'return error_not_found unless ENV["FINDER_FRONTEND_ENABLE_QA"]' is removed from the QAController
1 change: 0 additions & 1 deletion spec/controllers/qa_controller_spec.rb
View file
Open in desktop
Expand Up @@ -6,7 +6,6 @@
include FixturesHelper
include GovukContentSchemaExamples
render_views
ENV["FINDER_FRONTEND_ENABLE_QA"] = "true"

describe "GET show" do
let(:aaib_reports_finder) { aaib_reports_content_item }
Expand Down
1 change: 0 additions & 1 deletion spec/controllers/qa_to_content_controller_spec.rb
View file
Open in desktop
Expand Up @@ -4,7 +4,6 @@
describe QaToContentController, type: :controller do
include FixturesHelper
render_views
ENV["FINDER_FRONTEND_ENABLE_QA_TO_CONTENT"] = "true"

describe "GET show" do
let(:uk_nationals_in_eu_yaml) { uk_nationals_in_eu_config }
Expand Down